Close the read/recv loop if we receive {:error, "socket closed"} #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chen-anders
force-pushed
the
anders/debug-socket-closed
branch
2 times, most recently
from
d7c00de to
ba227c3
Compare
chen-anders
changed the title
chen-anders
force-pushed
the
anders/debug-socket-closed
branch
from
ba227c3 to
47b0c9d
Compare
kminevskiy
approved these changes
Dec 20, 2023
michaelorr
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds handling for
{:error, "socket closed"}similar to how the reference golang client handles these issues by closing the connection: https://github.com/nsqio/go-nsq/blob/master/conn.go#L50Closing the connection in our case also terminates the process, which will cause the supervisor to spin up a new process.