Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update node image.endpoint config structure #13190

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

lee-arnold
Copy link

@lee-arnold lee-arnold commented Feb 7, 2025

Changes

  • Astro 5 made changes to the image endpoint config
  • This PR makes those structure changes in the node adapter
  • For whatever reason, the old state of the config only created issues when built and executed in a docker container

Fixes #13183

Testing

  • Tested locally (with some difficulty) by heavily modifying the SSR example and running it locally in a docker container

Docs

  • N/A

Copy link

changeset-bot bot commented Feb 7, 2025

🦋 Changeset detected

Latest commit: c0f49f2

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Feb 7, 2025
@lee-arnold lee-arnold changed the title fix: update image.endpoint config structure fix: update node image.endpoint config structure Feb 7, 2025
@ematipico
Copy link
Member

Can you please add a test (if it's possible) and a changeset?

@ematipico
Copy link
Member

@lee-arnold are you still interested in the PR?

@lee-arnold
Copy link
Author

Yes, apologies - chaotic start to the week. Will get on the changeset now.

If you have any, I would love some advice on what you think might be an appropriate test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[@astrojs/node] Image endpoint using default settings 404 in production after Astro v5
2 participants