Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Adds clarity around output setting log statement #13212

Merged
merged 6 commits into from
Feb 12, 2025

Conversation

joshmkennedy
Copy link
Contributor

@joshmkennedy joshmkennedy commented Feb 11, 2025

Changes

This pull request is an attempt to solve #13192

Changes the output log statement to log the output and not the buildOutput.
I have added an additional log to show if an adapter is setup for ssr, which is what I believe was the intent of this log line being changed in commit fix(core): add error log for server islands.

-		this.logger.info('build', `output: ${blue('"' + this.settings.config.output + '"')}`);
+		this.logger.info('build', `output: ${blue('"' + this.settings.buildOutput + '"')}`);

Testing

No tests were added as the only changes are to log statements

Docs

Copy link

changeset-bot bot commented Feb 11, 2025

🦋 Changeset detected

Latest commit: bd05191

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Feb 11, 2025
@joshmkennedy
Copy link
Contributor Author

I could be wrong about the intent of the log line here.
Is there a more correct way to show the distinction here?

Copy link

codspeed-hq bot commented Feb 11, 2025

CodSpeed Performance Report

Merging #13212 will not alter performance

Comparing joshmkennedy:fix-log-output-setting (bd05191) with main (9d56602)

Summary

✅ 6 untouched benchmarks

@ematipico ematipico merged commit fb38840 into withastro:main Feb 12, 2025
16 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants