Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(fr): update guides/upgrade-to/v5.mdx and guides/client-side-scripts.mdx #10687

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

MoustaphaDev
Copy link
Member

Description (required)

Updates guides/upgrade-to/v5.mdx and guides/client-side-scripts.mdx to add changes from #10656.

Related issues & labels (optional)

  • Suggested label: i18n

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Jan 10, 2025
Copy link

netlify bot commented Jan 10, 2025

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 46da331
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6781695757fec400084f3a21
😎 Deploy Preview https://deploy-preview-10687--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Jan 10, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
fr/guides/client-side-scripts.mdx Localization changed, will be marked as complete.
fr/guides/upgrade-to/v5.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@sarah11918 sarah11918 added the merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) label Jan 10, 2025
@sarah11918
Copy link
Member

sarah11918 commented Jan 10, 2025

Just a reminder that this can't merge until a) the feature is released and then also b) the English is released!! (or the page will have the wrong "translated" status.

Astro Release > English docs merged > translated docs can merge

@MoustaphaDev
Copy link
Member Author

Got it, will keep that in mind.

Copy link
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some typo/nit, otherwise LGTM. Thanks!

src/content/docs/fr/guides/upgrade-to/v5.mdx Outdated Show resolved Hide resolved
src/content/docs/fr/guides/upgrade-to/v5.mdx Outdated Show resolved Hide resolved
src/content/docs/fr/guides/upgrade-to/v5.mdx Outdated Show resolved Hide resolved
src/content/docs/fr/guides/upgrade-to/v5.mdx Outdated Show resolved Hide resolved
@ArmandPhilippot
Copy link
Member

Thanks for the quick updates!, @MoustaphaDev! Maybe I should leave the Requested change status until the English version is published to avoid an accidental merge? Otherwise, happy to approve now!

@MoustaphaDev
Copy link
Member Author

MoustaphaDev commented Jan 10, 2025

Thanks for the quick updates!, @MoustaphaDev

Thank you for the reviews!

Maybe I should leave the Requested change status until the English version is published to avoid an accidental merge?

Sure, that sounds like a good plan 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants