Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update layouts.mdx #10690

Merged
merged 4 commits into from
Jan 13, 2025
Merged

docs: update layouts.mdx #10690

merged 4 commits into from
Jan 13, 2025

Conversation

jsparkdev
Copy link
Contributor

Description (required)

Related issues & labels (optional)

  • Closes #
  • Suggested label:

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Jan 11, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/basics/layouts.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link

netlify bot commented Jan 11, 2025

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b160c72
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/67852454f4a1ae00089051df
😎 Deploy Preview https://deploy-preview-10690--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for snagging this issue @jsparkdev ! Removing the sentence is perfect, but I commented below that I don't think we should change our example from the common use!

src/content/docs/en/basics/layouts.mdx Outdated Show resolved Hide resolved
@sarah11918 sarah11918 added the improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) label Jan 13, 2025
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you! 💜

@jsparkdev jsparkdev added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Jan 13, 2025
@sarah11918
Copy link
Member

Ugh, will look into the failed Netlify deploy and see whether it was just a fluke!

@jsparkdev
Copy link
Contributor Author

It seems to be working now. Thank you!

@jsparkdev jsparkdev merged commit 197fe8f into withastro:main Jan 13, 2025
10 checks passed
@jsparkdev jsparkdev deleted the layouts-update branch January 13, 2025 14:59
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants