Add support for string-keyed attrs in from functions
#7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 11, 2024 11:50
Since we're using Ecto.Changeset.cast, `new` already supported `attrs` being string-keyed. Alter the `from` function to do similar functionality for the provided `attrs`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for string-keyed
attrsinfromfunctionsSince we're using Ecto.Changeset.cast,
newalready supportedattrsbeing string-keyed as thecastfunction accepts either atom or string keyed maps and appropriately sets the struct fields.However, the original
fromfunction did a simpleMap.mergeof the givenattrs. This resulted in a mix-key map being given to thenewfunction.Alter the
fromfunction to cast attrs to get an atom-keyed map of attributes which then merged as normal with the originalbase_struct