Skip to content

Commit

Permalink
Fix issues with spec gen
Browse files Browse the repository at this point in the history
  • Loading branch information
grant0417 committed May 30, 2024
1 parent 4017cf4 commit d459a50
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions src/aws_cli_plugin/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ def awscli_initialize(cli):
cli.register("building-command-table", read_commands)


def stripHTML(text):
return re.sub("<[^<]+?>", "", text).strip()
def cleanDescription(text):
return re.sub("<[^<]+?>", "", text).strip().rstrip(".").strip()


def argumentsDictionary(args):
Expand All @@ -27,7 +27,7 @@ def argumentsDictionary(args):
if arg.choices is None or isinstance(arg.choices, list)
else list(arg.choices)
)
description = stripHTML(arg.documentation)
description = cleanDescription(arg.documentation)
variadic = arg.nargs is not None and arg.nargs == "+"
# print(arg.cli_name, arg.nargs, arg.required)
# js = { "name": arg.cli_name, "type": arg.cli_type_name, "nargs": arg.nargs, "required": arg.required, "documentation": arg.documentation, "suggestions": arg.choices}
Expand All @@ -41,7 +41,7 @@ def argumentsDictionary(args):
raw["suggestions"] = choices
# raw["isOptional"] = not arg.required
if variadic:
raw["variadic"] = variadic
raw["isVariadic"] = variadic

positional.append(raw)
elif arg.cli_type_name == "boolean":
Expand All @@ -53,7 +53,7 @@ def argumentsDictionary(args):
# raw["isOptional"] = not arg.required

if variadic:
raw["args"]["variadic"] = variadic
raw["args"]["isVariadic"] = variadic
flags.append(raw)

return (flags, positional)
Expand All @@ -66,7 +66,7 @@ def generateCompletionSpecSkeleton(name, command):
operation = command_table[operation_name]
if isinstance(operation, ServiceOperation):
(flags, args) = argumentsDictionary(operation.arg_table)
description = stripHTML(operation._operation_model.documentation)
description = cleanDescription(operation._operation_model.documentation)

subcommand = {"name": operation_name}

Expand All @@ -90,7 +90,7 @@ def generateCompletionSpecSkeleton(name, command):

spec = {
"name": name,
"description": stripHTML(command.service_model.documentation),
"description": cleanDescription(command.service_model.documentation),
"subcommands": subcommands,
}

Expand Down Expand Up @@ -151,7 +151,7 @@ def parseBasicCommand(command):

def saveJsonAsSpec(d, path):
prefix = (
"export const completionSpec: Fig.Spec = "
"const completionSpec: Fig.Spec = "
if exportTypescript
else "var completionSpec = "
)
Expand Down

0 comments on commit d459a50

Please sign in to comment.