Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: status and statusDetails logic #30

Merged
merged 3 commits into from
Feb 16, 2024
Merged

fix: status and statusDetails logic #30

merged 3 commits into from
Feb 16, 2024

Conversation

noomorph
Copy link
Collaborator

@noomorph noomorph commented Feb 15, 2024 •
edited
Loading

Work in progess.

Fixes logic of stage, status and statusDetails fields:

  • Handle correctly failed snapshot assertions – use finished stage and not interrupted, use failed status and not passed.
  • Distinguish between interrupted and finished tests more clearly.
  • Custom user overrides should be prioritized over default Jest and jest-allure2-reporter values (except for failed tests and steps)
  • Metadata properties should be optional, meaningful, and unique – avoid overlapping with standard Jest reporter data where possible.
  • Unified error formatting.

@noomorph noomorph marked this pull request as ready for review February 16, 2024 11:20
@noomorph noomorph force-pushed the fix/snapshot-tests branch 2 times, most recently from 683778c to 85e1276 Compare February 16, 2024 12:36
@noomorph noomorph merged commit 0e198f0 into beta Feb 16, 2024
3 checks passed
@noomorph noomorph deleted the fix/snapshot-tests branch February 16, 2024 17:20
@github-actions GitHub Actions
Copy link
Contributor

🎉 This PR is included in version 2.0.0-beta.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@noomorph