Change mag min filter to linear (#54)

* Changed MAG/MIN texture filtering from NEAREST to LINEAR * 0.14.0
wix-incubator · Dec 14, 2024 · 9528d2b · 9528d2b
1 parent 14d7e18
commit 9528d2b
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 10 deletions.
diff --git a/dist/index.cjs b/dist/index.cjs
@@ -3167,8 +3167,8 @@ function createTexture(
         gl.TEXTURE_WRAP_T,
         gl[_getTextureWrap(wrap.y || wrap)],
     );
-    gl.texParameteri(gl.TEXTURE_2D, gl.TEXTURE_MIN_FILTER, gl.NEAREST);
-    gl.texParameteri(gl.TEXTURE_2D, gl.TEXTURE_MAG_FILTER, gl.NEAREST);
+    gl.texParameteri(gl.TEXTURE_2D, gl.TEXTURE_MIN_FILTER, gl.LINEAR);
+    gl.texParameteri(gl.TEXTURE_2D, gl.TEXTURE_MAG_FILTER, gl.LINEAR);
 
     if (data) {
         // Upload the image into the texture

diff --git a/index.umd.js b/index.umd.js
@@ -3171,8 +3171,8 @@ void main() {
             gl.TEXTURE_WRAP_T,
             gl[_getTextureWrap(wrap.y || wrap)],
         );
-        gl.texParameteri(gl.TEXTURE_2D, gl.TEXTURE_MIN_FILTER, gl.NEAREST);
-        gl.texParameteri(gl.TEXTURE_2D, gl.TEXTURE_MAG_FILTER, gl.NEAREST);
+        gl.texParameteri(gl.TEXTURE_2D, gl.TEXTURE_MIN_FILTER, gl.LINEAR);
+        gl.texParameteri(gl.TEXTURE_2D, gl.TEXTURE_MAG_FILTER, gl.LINEAR);
 
         if (data) {
             // Upload the image into the texture

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "kampos",
-    "version": "0.13.1",
+    "version": "0.14.0",
     "description": "Tiny and fast effects compositor on WebGL",
     "registry": "https://registry.npmjs.org/",
     "main": "dist/index.cjs",

diff --git a/src/core.js b/src/core.js
@@ -664,8 +664,8 @@ export function createTexture(
         gl.TEXTURE_WRAP_T,
         gl[_getTextureWrap(wrap.y || wrap)],
     );
-    gl.texParameteri(gl.TEXTURE_2D, gl.TEXTURE_MIN_FILTER, gl.NEAREST);
-    gl.texParameteri(gl.TEXTURE_2D, gl.TEXTURE_MAG_FILTER, gl.NEAREST);
+    gl.texParameteri(gl.TEXTURE_2D, gl.TEXTURE_MIN_FILTER, gl.LINEAR);
+    gl.texParameteri(gl.TEXTURE_2D, gl.TEXTURE_MAG_FILTER, gl.LINEAR);
 
     if (data) {
         // Upload the image into the texture

diff --git a/test/e2e/video-effects.js b/test/e2e/video-effects.js
@@ -1478,7 +1478,7 @@ test('channelSplit red cyan', async (ctx) => {
     );
 
     // TODO: fix by taking the correct snapshots excluding the sides
-    expect(diffPixels).toBe(7680); // expect the 7680 pixels of the horizontal sides to be different
+    expect(diffPixels).toBe(7822); // expect the 7680 pixels of the horizontal sides to be different + 142 pixels of the gl.LINEAR filtering
 });
 
 test('channelSplit magenta green', async (ctx) => {