SWC plugin for Vite and NextJS #186
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
guyca
requested changes
Oct 26, 2024
| @@ -0,0 +1,11 @@ | |||
| # react-obsidian | |||
There was a problem hiding this comment.
Do you plan on adding short docs or description here? If not I think we can remove the file. Even 1-2 lines is enough, we'll document this in the installation section.
| { | ||
| "name": "swc-plugin-obsidian", | ||
| "version": "3.0.0-alpha.6", | ||
| "description": "Dependency injection framework for React and React Native applications", |
There was a problem hiding this comment.
Don't forget to update the description.
| "build": "tsc --project tsconfig.json", | ||
| "pretest": "tsc --project tsconfig.json", | ||
| "test": "npx jest", | ||
| "test-coverage": "npx jest --coverage" |
There was a problem hiding this comment.
We don't have unit tests so I guess we can remove the coverage script?
| "globals": "^15.9.0", | ||
| "jest": "29.7.x", | ||
| "jest-environment-jsdom": "^29.7.0", | ||
| "jest-extended": "^4.0.0", |
There was a problem hiding this comment.
Some of these dependencies aren't used - we should clean up the dev dependencies later. I'm pretty sure jest-extended and jest-when aren't used.
guyca
changed the title
|
Closing in favor of #190 . Thanks @zacharyweidenbach for your hard work 👑 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implementation, fails to compile due to module compat issue