Skip to content

Commit

Permalink
fix: removing @ts-ignore from everywhere except tests
Browse files Browse the repository at this point in the history
  • Loading branch information
BrooklynKing committed Mar 4, 2019
1 parent ff9290f commit 04b525f
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 12 deletions.
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@
"@babel/types": "7.0.0-beta.46",
"@types/chai": "^4.1.7",
"@types/chance": "^1.0.1",
"@types/classnames": "^2.2.7",
"@types/hls.js": "^0.10.2",
"@types/mocha": "^5.2.5",
"@types/node": "^10.12.3",
Expand Down
5 changes: 2 additions & 3 deletions src/adapters/dash.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
//@ts-ignore
import { MediaPlayer } from 'dashjs/build/es5/index_mediaplayerOnly';

import { getNearestBufferSegmentInfo } from '../utils/video-data';
Expand Down Expand Up @@ -53,8 +52,8 @@ export default class DashAdapter implements IPlaybackAdapter {
get currentUrl() {
return this.mediaStream.url;
}
//@ts-ignore
get syncWithLiveTime() {

get syncWithLiveTime(): any {
// TODO: implement syncWithLiveTime for `dash`
return undefined;
}
Expand Down
1 change: 0 additions & 1 deletion src/adapters/hls.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
//@ts-ignore
import HlsJs from 'hls.js/dist/hls.light';

import {
Expand Down
9 changes: 4 additions & 5 deletions src/core/player-facade.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,10 @@ import { PLAYER_API_PROPERTY } from '../core/player-api-decorator';
import { IThemeConfig } from '../modules/ui/core/theme';

export default class Player {
//@ts-ignore
private _config: IPlayerConfig;
private _scope: Container;
private _defaultModules: { [id: string]: any };
private _additionalModules: { [id: string]: any };
protected _config: IPlayerConfig;
protected _scope: Container;
protected _defaultModules: { [id: string]: any };
protected _additionalModules: { [id: string]: any };
private _destroyed: boolean;

constructor(
Expand Down
4 changes: 2 additions & 2 deletions src/modules/playback-engine/adapters/native.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ export default function getNativeAdapterCreator(
get currentUrl() {
return this.mediaStreams[this.currentLevel].url;
}
//@ts-ignore
get syncWithLiveTime() {

get syncWithLiveTime(): any {
// TODO: implement syncWithLiveTime for `native`
return undefined;
}
Expand Down
1 change: 0 additions & 1 deletion src/modules/ui/core/extendStyles.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
//@ts-ignore
import classnames from 'classnames';
import { IStyles } from './types';

Expand Down
2 changes: 2 additions & 0 deletions src/typings/internals.d.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
declare module '*.scss';
declare module '*.svg';
declare module '*.dot';

declare module 'dashjs/build/es5/index_mediaplayerOnly';

0 comments on commit 04b525f

Please sign in to comment.