Move to monorepo #264
Merged
Move to monorepo #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielKag
force-pushed
the
monorepo
branch
4 times, most recently
from
64ed3f0 to
5c0e0ca
Compare
DanielKag
commented
Jan 28, 2025
| @@ -0,0 +1 @@ | |||
| //registry.npmjs.org/:_authToken=${NPM_AUTH_TOKEN} | |||
There was a problem hiding this comment.
We can't run npm set registry on a package level.
Adding this file will enable us to publish to the public npm registry without calling npm set registry in the action
DanielKag
commented
Jan 28, 2025
.github/workflows/release.yml
Outdated
| @@ -6,7 +6,7 @@ on: | |||
| yarnVersionArgs: | |||
| description: 'Arguments for "yarn version"' | |||
| required: true | |||
| default: '--patch' | |||
There was a problem hiding this comment.
In yarn berry the command changed to:
yarn version patch
DanielKag
commented
Jan 28, 2025
| echo PR package tag is [pr$PR_ID.$BUILD_NUMBER] | ||
| npm config set //registry.npmjs.org/:_authToken=$NPM_AUTH_TOKEN |
There was a problem hiding this comment.
Added .npmrc file in the root instead
DanielKag
commented
Jan 28, 2025
.github/workflows/release.yml
Outdated
| - name: Bump version | ||
| run: | | ||
| git reset --hard | ||
| yarn version --no-git-tag-version ${{ github.event.inputs.yarnVersionArgs }} |
There was a problem hiding this comment.
we can't use --no-git-tag-version in yarn berry
Fix matrix fix node version Run only repluggable Downgrade yarn bla bla2 bla3 pr.yml pr.ym2l run registry npmrc release
itsh01
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.