This repository has been archived by the owner on Nov 1, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
DatePicker - adding better year selection #580
Open
Zombiefruit
wants to merge
17
commits into
master
Choose a base branch
from
kieran/datepicker-better-year-selection
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
7c30ed5
Adding basic month selection
92b56a7
Added tests for date selection, month selection is finished
ce3c89d
Merge branch 'master' into kieran/datepicker-better-date-selection
9db7eef
Merge branch 'master' into kieran/datepicker-better-date-selection
e2ae1de
Better wording
4f17f56
First commits
7434e9d
Merge branch 'master' into kieran/datepicker-better-year-selection
001f28f
Tests are passing
b701a2f
Merge branch 'master' into kieran/datepicker-better-year-selection
3f28429
Refactored
bb9260e
Removed blank lines
99d26be
Added comment
f972863
Changed behaviour
3c0b7e9
Renamed state
a167806
Merge branch 'master' into kieran/datepicker-better-year-selection
ea1c953
Made some changes
1b28e01
Merge branch 'master' into kieran/datepicker-better-year-selection
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -165,6 +165,10 @@ | |
-st-extends: calendar; | ||
} | ||
|
||
.year-view { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just one last detail, this should be in camel case. |
||
-st-extends: calendar; | ||
} | ||
|
||
/* Styling for the days of the week */ | ||
.dayName { | ||
font-family: value(fontFamily); | ||
|
@@ -196,6 +200,24 @@ | |
background-color: value(color_Keyboard_Focused); | ||
} | ||
|
||
.year { | ||
/* 100/2 = 50... show 2 years per row */ | ||
flex: 0 0 50%; | ||
line-height: 54px; | ||
font-family: value(fontFamily); | ||
font-size: 14px; | ||
font-weight: bold; | ||
text-align: center; | ||
color: value(color_MainText); | ||
cursor: pointer; | ||
} | ||
|
||
/* Hover styles for year selection */ | ||
.year:hover { | ||
color: value(color_MainText); | ||
background-color: value(color_Keyboard_Focused); | ||
} | ||
|
||
/* Styling for the days of the month */ | ||
.day { | ||
-st-states: focused, selected, current, inactive, disabled; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this
span
necessary to wrap the DOM you get back fromgetHeader()
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really, but the alternative is duplicating those attributes on all three of the possible return values for getHeader