fix(webpack-plugin): crash with [email protected] (#2262)

wix · Jan 12, 2022 · df3a4ae · df3a4ae
1 parent ffa4b4a
commit df3a4ae
Show file tree

Hide file tree

Showing 3 changed files with 49 additions and 46 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -80,7 +80,7 @@
     "ts-expect": "^1.3.0",
     "typescript": "~4.5.4",
     "url-loader": "^4.1.1",
-    "webpack": "^5.65.0"
+    "webpack": "^5.66.0"
   },
   "engines": {
     "node": ">=12"

diff --git a/packages/webpack-plugin/src/plugin-utils.ts b/packages/webpack-plugin/src/plugin-utils.ts
@@ -108,6 +108,7 @@ export function replaceMappedCSSAssetPlaceholders({
             if (isLoadedWithKnownAssetLoader(assetModule)) {
                 return extractFilenameFromAssetModule(assetModule, publicPath);
             } else {
+                const data = new Map<string, unknown>();
                 const assetModuleSource = assetModule.generator.generate(assetModule, {
                     chunkGraph,
                     moduleGraph,
@@ -116,9 +117,11 @@ export function replaceMappedCSSAssetPlaceholders({
                     runtimeTemplate,
                     dependencyTemplates,
                     type: 'asset/resource',
+                    getData: () => data,
                 });
 
                 if (assetModule.buildInfo.dataUrl) {
+                    // Investigate using the data map from getData currently there is an unknown in term from escaping keeping extractDataUrlFromAssetModuleSource
                     return extractDataUrlFromAssetModuleSource(
                         assetModuleSource.source().toString()
                     );