Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(define-remix-app): invalid input with initial underscore #1254

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

idoros
Copy link
Contributor

@idoros idoros commented Nov 4, 2024

This PR fixes an incorrect error message for new page names that start with an underscore (_).
Previously, entering a name like _page would incorrectly trigger the message:

"Page name cannot be empty."

Now, the message accurately reflects the input:

"Page names must start with a letter of the alphabet."

@idoros idoros added the bug Something isn't working label Nov 4, 2024
@idoros idoros self-assigned this Nov 4, 2024
@Eg0ld Eg0ld merged commit db35260 into master Nov 4, 2024
6 checks passed
@Eg0ld Eg0ld deleted the ido/fix-new-page-name-validation branch November 4, 2024 12:42
Eg0ld added a commit that referenced this pull request Nov 4, 2024
@Eg0ld Eg0ld restored the ido/fix-new-page-name-validation branch November 4, 2024 12:48
@PeterShershov PeterShershov deleted the ido/fix-new-page-name-validation branch November 4, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants