feat: implement plugable map combined with event emitter #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idoros
reviewed
May 4, 2023
packages/plugable/src/plugable.ts
Outdated
| @@ -0,0 +1,96 @@ | |||
| import { type Plugable, type Key, internals, PlugableInternals, Val } from './types'; | |||
|
|
|||
| const proto = { | |||
There was a problem hiding this comment.
maybe inline the functions on the proto instead of proxy them?
also set the Plugable type.
| set(parent, key, 'hello'); | ||
|
|
||
| expect(res[0]).to.equal('hello'); | ||
| }); |
There was a problem hiding this comment.
missing tests:
- inherited record doesn't effect the origin
- call return value of
on()to stop listening - listen with multiple listeners (check that removing 1 doesn't change the others)
| }); | ||
| }); | ||
|
|
||
| describe('Plugable (prototype api)', () => { |
There was a problem hiding this comment.
what is this test for? seems like you test the API in the previous tests.
There was a problem hiding this comment.
This is related all the other tests checking the non prototype api.
at this point I'm not sure which one is preferred WDYT?
* use getThrow * improve set default value perf
* add more tests * expose createKey on the api
daomry
requested changes
Jun 20, 2023
daomry
requested changes
Jul 10, 2023
This is very wordy but I didn't get what's it's used for. can you plz explain? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.