fix: change order of dispose browser context

wixplosives · Nov 30, 2023 · 7ec33ed · 7ec33ed
1 parent 417847c
commit 7ec33ed
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/packages/test-kit/src/with-feature.ts b/packages/test-kit/src/with-feature.ts
@@ -335,6 +335,12 @@ export function withFeature(withFeatureOptions: IWithFeatureOptions = {}) {
                     throw new Error('Browser is not open!');
                 }
                 dedicatedBrowserContext = await browser.newContext(browserContextOptions);
+
+                dispose(() => dedicatedBrowserContext?.close(), {
+                    group: WITH_FEATURE_DISPOSABLES,
+                    name: `close browser context for feature "${featureName}"`,
+                    timeout: 5000,
+                });
 
                 await enableTestBrowserContext({
                     browserContext: dedicatedBrowserContext,
@@ -346,11 +352,6 @@ export function withFeature(withFeatureOptions: IWithFeatureOptions = {}) {
                     capturedErrors,
                     consoleLogAllowedErrors,
                 });
-                dispose(() => dedicatedBrowserContext?.close(), {
-                    group: WITH_FEATURE_DISPOSABLES,
-                    name: `close browser context for feature "${featureName}"`,
-                    timeout: 5000,
-                });
             }
 
             if (!executableApp) {