Bump bdk_coin_select to 0.3.0 #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `score` method of the `LowestFee` metric has been fixed and so our temporary fix is no longer required. The `min_fee` parameter of `select_coins_for_spend`, if positive, now ensures that RBF rule 4 is satisfied. `base_weight` is no longer stored in `CoinSelector` and instead the output weights are stored in `Target`. This means that the `output_weight` of `DrainWeights` no longer needs to take into account a potential change in output count varint.
RBF rule 4 is now enforced by coin selection.
The parameter has been renamed and changed to `Option` as it is only required when creating a replacement transaction using RBF.
darosior
approved these changes
Apr 15, 2024
| if base_tx.input.is_empty() { | ||
| base_weight = base_weight.saturating_sub(2); | ||
| } | ||
| let out_weight_nochange: u32 = { |
There was a problem hiding this comment.
style nit: could have used iter().map().sum() to match the previous line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to resolve #923.
The
scoremethod of theLowestFeemetric has been fixed upstream and so our temporary partial fix from #867 is no longer required.The
min_feeparameter ofselect_coins_for_spend, if positive, now ensures that RBF rule 4 is satisfied. Accordingly, it has been renamed toreplaced_feeand made anOption. We could potentially have used theSpendTxFeesenum as a parameter directly instead offeerate_vbandreplaced_fee, butfeerate_vbis currentlyf32rather thanu64and so I kept them as separate parameters.Thanks to how the
replaced_feeparameter works, the fee iteration approach used inrbf_psbtto ensure the replacement satisfies RBF rule 4 is no longer required.base_weightis no longer stored inCoinSelectorand instead the output weights are stored inTarget. This means that theoutput_weightofDrainWeightsno longer needs to take into account a potential change in output count varint as this is now handled by bdk_coin_select.The min value for change no longer includes the threshold itself and so we have to subtract 1 from our change policy's min value (see bitcoindevkit/coin-select#14 (comment)). We already have a test that fails without this subtraction as it expects a change output of 5000 sats.