Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gui(installer): use fixed keys ordering #1442

Merged
merged 1 commit into from
Nov 6, 2024
Merged

gui(installer): use fixed keys ordering #1442

merged 1 commit into from
Nov 6, 2024

Conversation

jp1ac4
Copy link
Collaborator

@jp1ac4 jp1ac4 commented Nov 6, 2024

This is to fix #1439. It follows the same approach as used in the settings to ensure consistent ordering when iterating over keys.

@jp1ac4
gui(installer): use fixed keys ordering
86cebc2 
This follows the same approach as used in the settings.
@edouardparis
Copy link
Member

edouardparis commented Nov 6, 2024 •
edited
Loading

I think it would be cleaner to change the keys alias map in Context struct for a BTreeMap for which iterators always respect an order. Thresh_origins result map is the culprit

edouardparis
edouardparis approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@edouardparis edouardparis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 86cebc2

@edouardparis edouardparis merged commit ff968ea into wizardsardine:master Nov 6, 2024
31 checks passed
@jp1ac4 jp1ac4 mentioned this pull request Nov 6, 2024
Merged
edouardparis added a commit that referenced this pull request Nov 6, 2024
@edouardparis
Merge #1444: backport for v8: #1442: gui(installer): use fixed keys o…
07f135e 
…rdering

82ef34e gui(installer): use fixed keys ordering (Michael Mallan)

Pull request description:

  Backport of #1442.

ACKs for top commit:
  edouardparis:
    utACK 82ef34e

Tree-SHA512: 4445cf37608a8d9f42512d25d3b54129e8d8d525fe73912f9cf23a18722d9deb5545304c80558f6afc202e7e04ef2a3d98caf6e1111f17aa958ef8aca1125d98
@jp1ac4 jp1ac4 deleted the gui-use-fixed-keys-ordering branch November 6, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edouardparis edouardparis edouardparis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Aliases order in the wallet policy descriptor changes according to check on descriptor registration
2 participants
@jp1ac4 @edouardparis