Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 2 decimal for sync progression in home page #1462

Conversation

thomask7b
Copy link
Contributor

Did the update for the home page.
For the loading screen (IBD) it was already formatting with 2 decimal, see loader.rs:450

Solves #907

@thomask7b thomask7b force-pushed the fix-907-blockchain-sync-progress branch from 19e4531 to fc607c9 Compare November 13, 2024 16:28
@pythcoiner
Copy link
Collaborator

can you run:

cd gui && cargo update -p liana

in order to update the daemon dependency?

@thomask7b thomask7b force-pushed the fix-907-blockchain-sync-progress branch from fc607c9 to d9d93cc Compare November 13, 2024 16:45
@pythcoiner
Copy link
Collaborator

tACK d9d93cc
image

Copy link
Collaborator

@jp1ac4 jp1ac4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK d9d93cc.

Home page and loading screen are showing 2 decimal places.

Thanks!

@jp1ac4
Copy link
Collaborator

jp1ac4 commented Nov 15, 2024

Sorry you'll need to rebase this branch on master following the merging of #1448.

@thomask7b thomask7b closed this Nov 15, 2024
@thomask7b thomask7b deleted the fix-907-blockchain-sync-progress branch November 15, 2024 16:06
@thomask7b
Copy link
Contributor Author

Reopened #1465

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants