bump bdk_coin_select to 0.4 #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jp1ac4
force-pushed
the
upgrade-coin-select-crate
branch
from
26c0da4 to
9cb17a7
Compare
Weights are now stored as `u64` instead of `u32`. The tests have been updated to reflect that coin selection now calculates feerates using a transaction's size in rounded-up vbytes.
jp1ac4
force-pushed
the
upgrade-coin-select-crate
branch
from
9cb17a7 to
1859a2d
Compare
|
Rebased on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Weights are now stored in the crate as
u64instead ofu32and so we can keep our weights and vsizes asu64.The tests have been updated to reflect that coin selection now calculates feerates using a transaction's size in rounded-up vbytes, which fixes #1132.