Grey out harware wallets when unrelated or do not support method #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edouardparis
force-pushed
the
filter-unsupported-wallets
branch
from
78dc7ee to
2c9a862
Compare
jp1ac4
reviewed
Dec 6, 2023
There was a problem hiding this comment.
I've tested 2c9a862 using Specter.
When it's not part of the wallet, it is greyed out and I cannot click it when verifying the receive address. When it's part of the wallet, it's again greyed out, but I'm still able to click it and an error message appears. Not sure if that's expected.
|
what is the error message please ? |
darosior
reviewed
Dec 7, 2023
edouardparis
force-pushed
the
filter-unsupported-wallets
branch
from
d40679a to
eb57d9b
Compare
|
Fixed the bug that let select grey out specter, fixed wording, rebased |
jp1ac4
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
ACK eb57d9b.
I tested again with Specter and it is now greyed out and not clickable in both cases (part of the wallet or not).
what is the error message please ?
The error message before was the same as the tooltip saying to check manually on the device.
edouardparis
force-pushed
the
filter-unsupported-wallets
branch
from
eb57d9b to
3372e2f
Compare
|
ACK 3372e2f. |
This was referenced Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #830