Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spend: Scale down the number of BnB rounds in debug mode and with a high number of candidates #856

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

darosior
Copy link
Member

@darosior darosior commented Dec 7, 2023

Based on #842.

Performing BnB with a large number of candidates can be computation expensive. Especially in debug mode. It can make the software lag in situations where it's called repeatedly.
Reasonably scale down the number of rounds performed depending on the number of candidates and whether optimizations are enabled.

Fixes #846

@darosior darosior force-pushed the 2312_reduce_bnb_rounds branch from 5425006 to c002ab9 Compare December 8, 2023 14:10
@darosior
Copy link
Member Author

darosior commented Dec 8, 2023

Rebased now that #842 is merged.

@darosior darosior requested a review from jp1ac4 December 8, 2023 14:11
@darosior darosior marked this pull request as ready for review December 8, 2023 14:11
Copy link
Collaborator

@jp1ac4 jp1ac4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c002ab9.

@darosior darosior merged commit fe14cbe into wizardsardine:master Dec 8, 2023
18 checks passed
@darosior darosior deleted the 2312_reduce_bnb_rounds branch December 8, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce the number of BnB iterations depending on the number of coins
2 participants