Expose spend module and coins fields #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edouardparis
commented
Dec 11, 2023
darosior
reviewed
Dec 11, 2023
edouardparis
force-pushed
the
expose-spend-module
branch
from
f7e3000 to
3e0a5ae
Compare
edouardparis
force-pushed
the
expose-spend-module
branch
from
3e0a5ae to
572567a
Compare
darosior
reviewed
Dec 11, 2023
darosior
added a commit
that referenced
this pull request
Dec 12, 2023
…oin selection a732468 spend: check max feerate (edouardparis) 4ccecd1 Use create_spend to calculate amount left to select (edouardparis) Pull request description: Fixes #822. based on #865 ACKs for top commit: jp1ac4: ACK a732468. Tree-SHA512: aa2728218d9ccf7b6511f881d88b262522705b4162b5b4235560626ee8b5b8c6d57e743ebfaf85dc633d6e3d2380badfe354a6dc4d19b89d3f380c63e123704e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to externally use create_spend, the spend module must be exposed and the listcoinsentry must include the derivation_index and is_change fields.