gui(spend): display warnings for draft PSBTs #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it looks to me:
|
|
As the warnings are only shown for the draft PSBT and disappear once saved, I've moved them outside of the overview card to give them a more temporary look. I've also removed the need to click on anything to see the warning(s). If there are no warnings, no message will be displayed.
This isn't possible for now as the warning messages are those returned from Here's a screenshot of the changes in 2466b93:
|
jp1ac4
force-pushed
the
gui-display-spend-creation-warnings
branch
from
2466b93 to
3efa761
Compare
|
Screenshot looks good to me. This PR needs (trivial) rebase. |
jp1ac4
force-pushed
the
gui-display-spend-creation-warnings
branch
from
3efa761 to
eb7cf5c
Compare
|
Rebased on master. |
jp1ac4
force-pushed
the
gui-display-spend-creation-warnings
branch
from
eb7cf5c to
85f5a68
Compare
|
Rebased on master to fix failing CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to complete #811.
It displays any warnings generated by
createspendon the draft PSBT view, which could currently be those from #905 and #873. Once the PSBT has been saved, these warnings will no longer be shown.Below are some screenshots.
With a warning:
Without a warning:
