Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly fallback to server_url when no override is set #506

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sheemap
Copy link

@Sheemap Sheemap commented Dec 27, 2024

Hey yall! This should resolve #482

Tested this and its fully working!

I havent actually tested this yet, Ive been having some trouble getting a local environment up and running to test this. Its a super small fix though, and Im fairly confident this will work.

If someone could validate real quick that this works, or if anyone is available to help me debug my environment, that would be appreciated!

Cause

Whenever the server_url_override is stored, it is defaulted to empty string if a value is not set. This ?? check will only take the right side if the left is null though, empty string does not qualify. So inadvertently, the href property gets set to blank.

Proposed fix

Switching out the ?? operator for || should fix the issue. Empty string will not be truthy, and it will pass through to the server_url

@Sheemap
Copy link
Author

Sheemap commented Dec 29, 2024

I was able to figure out my local env issues and fully verify this fixes it! Would love a review whenever you have some time @MrDynamo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] | server url can not redirect
1 participant