fix: correctly fallback to server_url when no override is set #506
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey yall! This should resolve #482
Tested this and its fully working!
I havent actually tested this yet, Ive been having some trouble getting a local environment up and running to test this. Its a super small fix though, and Im fairly confident this will work.If someone could validate real quick that this works, or if anyone is available to help me debug my environment, that would be appreciated!Cause
Whenever the
server_url_override
is stored, it is defaulted to empty string if a value is not set. This??
check will only take the right side if the left is null though, empty string does not qualify. So inadvertently, the href property gets set to blank.Proposed fix
Switching out the
??
operator for||
should fix the issue. Empty string will not be truthy, and it will pass through to the server_url