First deliverable #6
Conversation
controller/pokemon.go
Outdated
| pokemons, err := p.pokemonBusiness.GetAll() | ||
|
|
||
| if err != nil { | ||
| c.AbortWithStatus(http.StatusNotFound) |
There was a problem hiding this comment.
this is applicable for all endpoints, you must add a return statement after writing the response/response headers
Gin prevents overriding the status code, but other frameworks might override the 404 with the default status code, http 200 in this case
controller/pokemon.go
Outdated
| func (p pokemon) GetPokemonByID(c *gin.Context) { | ||
| id, err := strconv.Atoi(c.Params.ByName("pokemonId")) | ||
| if err != nil { | ||
| c.AbortWithStatus(http.StatusNotFound) |
There was a problem hiding this comment.
In case of an error, the API returns a 404 (all endpoints), please use the most appropriate HTTP return code
| package model | ||
|
|
||
| type Pokemon struct { | ||
| Id int `csv:"ID"` |
There was a problem hiding this comment.
Initialisms should be all underscored or all caps, i.e.: ID int csv:"ID"``
https://github.com/golang/go/wiki/CodeReviewComments#initialisms
controller/pokemon.go
Outdated
| c.AbortWithStatus(http.StatusNotFound) | ||
| } | ||
| pokemon, err := p.pokemonBusiness.GetByID(id) | ||
| if err != nil { |
There was a problem hiding this comment.
Is a good practice to log the errors in the uppermost layer or where you are handling them and returning something else (recovering from the error and returning a value or returning a different error)
can you please log the error here?
repository/pokemon.go
Outdated
| return nil, err | ||
| } | ||
| if err := gocsv.MarshalFile(&pokemons, pokemonFile); err != nil { | ||
| return nil, errors.New("There was a problem accesing to csv file") |
There was a problem hiding this comment.
by convention, error strings shouldn't be capitalized
https://github.com/golang/go/wiki/CodeReviewComments#error-strings
No description provided.