fix -Wmaybe-uninitialized warnings via missing [[noreturn]] a…

…nnotation
wjakob · Feb 12, 2024 · ba0ed85 · ba0ed85
1 parent 7614f47
commit ba0ed85
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 11 deletions.
diff --git a/include/nanobind/nb_cast.h b/include/nanobind/nb_cast.h
@@ -423,17 +423,7 @@ T cast(const detail::api<Derived> &value, bool convert = true) {
                                         : (uint8_t) 0, nullptr))
             detail::raise_cast_error();
 
-        // GCC misses that from_python will return or ensure orderly initialization
-        #if defined(__GNUC__) && !defined(__clang__)
-          #pragma GCC diagnostic push
-          #pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
-        #endif
-
         return caster.operator detail::cast_t<T>();
-
-        #if defined(__GNUC__) && !defined(__clang__)
-          #pragma GCC diagnostic pop
-        #endif
     }
 }
 

diff --git a/include/nanobind/nb_lib.h b/include/nanobind/nb_lib.h
@@ -103,7 +103,7 @@ NB_CORE void fail(const char *fmt, ...) noexcept;
 NB_CORE void raise_next_overload_if_null(void *p);
 
 /// Raise nanobind::cast_error
-NB_CORE void raise_cast_error();
+[[noreturn]] NB_CORE void raise_cast_error();
 
 // ========================================================================