Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple edit of annotations #1455

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Support multiple edit of annotations #1455

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83c4182
Support multiple edit of annotations
wkentaro Jun 13, 2024
90d27a4
Rename function name more pythonic
wkentaro Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
102 changes: 80 additions & 22 deletions labelme/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ def __init__(
self.flag_widget.itemChanged.connect(self.setDirty)

self.labelList.itemSelectionChanged.connect(self.labelSelectionChanged)
self.labelList.itemDoubleClicked.connect(self.editLabel)
self.labelList.itemDoubleClicked.connect(self._edit_label)
self.labelList.itemChanged.connect(self.labelItemChanged)
self.labelList.itemDropped.connect(self.labelOrderChanged)
self.shape_dock = QtWidgets.QDockWidget(self.tr("Polygon Labels"), self)
Expand Down Expand Up @@ -591,7 +591,7 @@ def __init__(

edit = action(
self.tr("&Edit Label"),
self.editLabel,
self._edit_label,
shortcuts["edit_label"],
"edit",
self.tr("Modify the label of the selected polygon"),
Expand Down Expand Up @@ -1087,27 +1087,78 @@ def validateLabel(self, label):
return True
return False

def editLabel(self, item=None):
if item and not isinstance(item, LabelListWidgetItem):
raise TypeError("item must be LabelListWidgetItem type")

def _edit_label(self, value=None):
if not self.canvas.editing():
return
if not item:
item = self.currentItem()
if item is None:
return
shape = item.shape()
if shape is None:

items = self.labelList.selectedItems()
if not items:
logger.warning("No label is selected, so cannot edit label.")
return

shape = items[0].shape()

if len(items) == 1:
edit_text = True
edit_flags = True
edit_group_id = True
edit_description = True
else:
edit_text = all(item.shape().label == shape.label for item in items[1:])
edit_flags = all(item.shape().flags == shape.flags for item in items[1:])
edit_group_id = all(
item.shape().group_id == shape.group_id for item in items[1:]
)
edit_description = all(
item.shape().description == shape.description for item in items[1:]
)

if not edit_text:
self.labelDialog.edit.setDisabled(True)
self.labelDialog.labelList.setDisabled(True)
if not edit_flags:
for i in range(self.labelDialog.flagsLayout.count()):
self.labelDialog.flagsLayout.itemAt(i).setDisabled(True)
if not edit_group_id:
self.labelDialog.edit_group_id.setDisabled(True)
if not edit_description:
self.labelDialog.editDescription.setDisabled(True)

text, flags, group_id, description = self.labelDialog.popUp(
text=shape.label,
flags=shape.flags,
group_id=shape.group_id,
description=shape.description,
)
text=shape.label if edit_text else "",
flags=shape.flags if edit_flags else None,
group_id=shape.group_id if edit_group_id else None,
description=shape.description if edit_description else None,
)

if not edit_text:
self.labelDialog.edit.setDisabled(False)
self.labelDialog.labelList.setDisabled(False)
if not edit_flags:
for i in range(self.labelDialog.flagsLayout.count()):
self.labelDialog.flagsLayout.itemAt(i).setDisabled(False)
if not edit_group_id:
self.labelDialog.edit_group_id.setDisabled(False)
if not edit_description:
self.labelDialog.editDescription.setDisabled(False)

if text is None:
assert flags is None
assert group_id is None
assert description is None
return

self.canvas.storeShapes()
for item in items:
self._update_item(
item=item,
text=text if edit_text else None,
flags=flags if edit_flags else None,
group_id=group_id if edit_group_id else None,
description=description if edit_description else None,
)

def _update_item(self, item, text, flags, group_id, description):
if not self.validateLabel(text):
self.errorMessage(
self.tr("Invalid label"),
Expand All @@ -1116,10 +1167,17 @@ def editLabel(self, item=None):
),
)
return
shape.label = text
shape.flags = flags
shape.group_id = group_id
shape.description = description

shape = item.shape()

if text is not None:
shape.label = text
if flags is not None:
shape.flags = flags
if group_id is not None:
shape.group_id = group_id
if description is not None:
shape.description = description

self._update_shape_color(shape)
if shape.group_id is None:
Expand Down Expand Up @@ -1176,7 +1234,7 @@ def shapeSelectionChanged(self, selected_shapes):
self.actions.delete.setEnabled(n_selected)
self.actions.duplicate.setEnabled(n_selected)
self.actions.copy.setEnabled(n_selected)
self.actions.edit.setEnabled(n_selected == 1)
self.actions.edit.setEnabled(n_selected)

def addLabel(self, shape):
if shape.group_id is None:
Expand Down
Loading