Drop support for out-of-support versions of Python, apply upgrade fixes #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @wkentaro – do you have the time to review this (and my other PRs, there's a handful...)? Thank you for maintaining the software! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup.pydeclares that the app supports Pythons down to Python 3.5, but the CI flow doesn't test on that version, and that version has been EOL for multiple years anyway.This PR hikes the minimum support version to Python 3.8 (which will be EOL in 2 months), and then mechanically applies the Ruff
UP(Pyupgrade) auto-fixes.I tested the app starts fine with these changes, but I'd assume CI/tests will take care of full coverage.