automatically create clubs from a csv file wowies #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "SOCIAL LINKS" | ||
| ] | ||
|
|
||
| assert np.array_equal(header, next(csv_reader)), "CSV layout changed since the last time the script was updated" |
There was a problem hiding this comment.
why use numpy and not just == ?
There was a problem hiding this comment.
didnt know python can do that
|
Yep, just compares to check if the content of both are the same. Please
remove the numpy dependency before I merge.
…On Mon, Feb 5, 2024, 12:56 AM pinwheeeel ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In core/management/commands/add_clubs.py
<#252 (comment)>:
> + with open(csv_file, 'r') as csv_file:
+ csv_reader = csv.reader(csv_file)
+ header = [
+ "CLUB NAME",
+ "APPROVED & MAILED",
+ "SAF PAID",
+ "PRESIDENT(S)",
+ "PRESIDENT(S) EMAIL",
+ "STAFF SUPERVISOR(S)",
+ "STAFF(S) EMAIL",
+ "BUDGET REQUEST",
+ "TIME + PLACE",
+ "SOCIAL LINKS"
+ ]
+
+ assert np.array_equal(header, next(csv_reader)), "CSV layout changed since the last time the script was updated"
didnt know python can do that
—
Reply to this email directly, view it on GitHub
<#252 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AP3WJYRFXRLG4BH5Y6ZBVNTYSBYCJAVCNFSM6AAAAABCZO62TOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNRRHEZTOOBTG4>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
Sorry to ask but could you just modify the input to either accept a flag that allows it to fetch it from URL or just change the logic to that? |
|
Oh okay, will work on it sometime later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#247
usage:
poetry run python ./manage.py add_clubs ./path_to_csv_file