Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): always test before publish #801

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/build_publish_image_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,15 @@ on:
- 'wdqs-proxy@*'
- 'wikibase@*'

# TODO: review permissions
permissions:
contents: write
packages: write

jobs:
_:
uses: ./.github/workflows/_build_test.yml

extract_tag_and_publish:
runs-on: ubuntu-latest

Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/create_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ on:
required: true
default: true

# TODO: review permissions
permissions:
contents: write
packages: write
Expand All @@ -36,7 +37,7 @@ jobs:
with:
fetch-tags: true
fetch-depth: 0
token: ${{ secrets.GH_WBS_BOT_TOKEN }}
token: ${{ secrets.GH_WBS_BOT_TOKEN }} # TODO: who do we need the bot token?

- uses: ./.github/actions/setup-environment
with:
Expand Down
2 changes: 2 additions & 0 deletions build/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,13 @@ if [ "$PUBLISH" == true ]; then
"${IMAGE_TAGS[@]}"
)
BUILD_ARGS+=("--push")

# build/test in CI
elif [ "$GITHUB_ACTIONS" == true ]; then
TAGS+=(
"dev-${GITHUB_RUN_ID}"
)

# local build
else
BUILD_ARGS+=("--load")
Expand Down