Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable testing the Dialog component on IE11 #524

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chukarave
Copy link
Contributor

Removed code that excluded tests on IE11.
Phab task: https://phabricator.wikimedia.org/T298256

@chukarave chukarave requested a review from guergana January 14, 2022 12:26
@github-actions
Copy link

@chukarave
Copy link
Contributor Author

Tests for IE11 on SauceLabs are failing on the lookup component for some reason.

@lucaswerkmeister
Copy link
Member

https://a89da689a7615a12845d0c979378f9c03d87e1b7--wmde-wikit.netlify.app

Hm, when I open this in my IE11 VM, I get an error on load:

SCRIPT1010: Expected identifier

That might not be directly related to the failing browser tests, though.

@chukarave
Copy link
Contributor Author

The Dialog tests are passing, it's failing to load a specific step for the Lookup Component https://app.saucelabs.com/tests/b1d35b604c4042e184beecfa9ac5e7c5
The code that was removed was strictly Dialog component related. Not sure why this is happening.

@chukarave
Copy link
Contributor Author

I ran it again, it passes now. Momentary snafu i guess.

@lucaswerkmeister
Copy link
Member

I still see a strange error in https://github.com/wmde/wikit/runs/4838744792?check_suite_focus=true:

  sauceIE  Results for:  resets dialog scroll bars to top when closed and reopened 
 sauceIE  ✔ Element <.***-Dialog> was present after 332 milliseconds. 
 sauceIE  Response 500 POST http://ondemand.saucelabs.com/wd/hub/session/15620d92940348c297d86d1c615b7ba2/execute (738ms) 
 sauceIE  { 
 sauceIE       status: 17, 
 sauceIE       sessionId: '15620d92940348c297d86d1c615b7ba2', 
 sauceIE       value: { message: 'JavaScript error' } 
 sauceIE  } 

Any idea what’s going on? I’m a bit confused at the moment.

@chukarave
Copy link
Contributor Author

Watching the video, this seems to be an error that occurs when the dialog window is reduced to a point when a scrollbar is added. I wasn't able to recreate this on my VM though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants