-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable testing the Dialog component on IE11 #524
base: master
Are you sure you want to change the base?
Conversation
Tests for IE11 on SauceLabs are failing on the lookup component for some reason. |
Hm, when I open this in my IE11 VM, I get an error on load:
That might not be directly related to the failing browser tests, though. |
The Dialog tests are passing, it's failing to load a specific step for the Lookup Component https://app.saucelabs.com/tests/b1d35b604c4042e184beecfa9ac5e7c5 |
I ran it again, it passes now. Momentary snafu i guess. |
I still see a strange error in https://github.com/wmde/wikit/runs/4838744792?check_suite_focus=true:
Any idea what’s going on? I’m a bit confused at the moment. |
Watching the video, this seems to be an error that occurs when the dialog window is reduced to a point when a scrollbar is added. I wasn't able to recreate this on my VM though. |
Removed code that excluded tests on IE11.
Phab task: https://phabricator.wikimedia.org/T298256