-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: outer_env issues fixed #874
Conversation
03e9762
to
827c8cf
Compare
87f0848
to
d52592c
Compare
9fe8f05
to
356ff7e
Compare
7e2dfcd
to
09217ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me, as it seems to fix the issue properly!
However for this one I'd like to hear what other maintainers think ;)
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
09217ba
to
c747bc1
Compare
Not sure about that, it's been open for nearly three months. ;) |
Yup, that's true, I was just a little concerned about some spots, but I've re-checked and everything is ok! |
Thanks! |
Fix #868. Two issues:
include_outer_env=False
does nothing at all ifenv=
is not passed. The outer env is still included.VIRTUAL_ENV
(required foruv
), andCONDA_PREFIX
(required for conda-family) would not be included if you do set both.Fixing this was a bit intrusive: now
.env
only is the local environmentsettings, and removals are added to it using None. The type has changed to match
.command
, with the None possibility. And then the final environment is built in the_run
, where it can correctly process things like adding the bin dir and filtering the None's.