-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial changes to VLCPlugin to enable playback with DiscoverySDK #22
Open
weberbry
wants to merge
10
commits into
master
Choose a base branch
from
Discover-SDK-enablement
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weberbry
commented
Nov 10, 2015
- Enables playback of audio from phonepap and DiscoverSDK
- Enables use of visual played from DiscoverSDK for phonegap and SDK content
@@ -8,6 +8,7 @@ | |||
#import "CDVReachability.h" | |||
#import "VLCPlugin.h" | |||
#import "DDLog.h" | |||
#import <MWFeedParser/NSString+HTML.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is MWFeedParser used for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was added to clean the HTML tags from the title property for the NYPRStream
…nor issues from PR comments
Use Discover-created playableUrl field to play Discover audio
…ge_to_js WNYCAPP-1497 pass display show message to javascript
… blocking main UI thread
…mpting_to_play_stream_on_bad_connection WNYCAPP-1514 initiate VLC library calls on background thread to avoid…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.