Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix edge cases where the number 0 is passed to an input #116

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

johnhyde
Copy link

This fixes this issue: wojtekmaj/react-datetime-picker#147
As well as an issue with showing leading zeroes.

Both issues stem from the fact that sometimes the value of the input element is the number 0 rather than the string "0", and since the number 0 is falsey, this value is interpreted as the input being empty when it's not.

@stevenkissack
Copy link

I've just been looking at a project that uses this library and was amazed to see if I added 00 for the minutes or seconds it ends up as "000"

This looks like maybe you're touching that area of code, would this pull request fix that?

Repro case: just go to the demo and type 00

Chrome v90 & Ubuntu 20.04

@johnhyde
Copy link
Author

@stevokk

This looks like maybe you're touching that area of code, would this pull request fix that?

Yes, it does, if I remember correctly. I'm hoping @wojtekmaj can find time to review this at some point, but if you don't want to wait for that you can always do what I did and fork react-datetime-picker, require my fork of react-time-picker, unignore the dist directory, build the library, and use it in your project with a GitHub url.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants