Support for Microchip Same51 #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
danielinux
commented
Dec 22, 2023
•
danielinux
commented
- hal support
- Dual-bank swapping
- update Target.md
- Add build test
dgarske
requested changes
Jan 31, 2024
.gdbinit
Outdated
| @@ -1,6 +1,7 @@ | |||
| tar rem:3333 | |||
| file wolfboot.elf | |||
| add-symbol-file test-app/image.elf | |||
| #add-symbol-file test-app/image.elf | |||
| add-symbol-file /home/dan/src/wolfboot/IDE/MPLabX/wolfBoot_usbUpdateApp.X/dist/default/production/wolfBoot_usbUpdateApp.X.production.elf | |||
| @@ -0,0 +1,113 @@ | |||
| # | |||
There was a problem hiding this comment.
Please consider using IDE/MPLABX to match our other libraries and Microchip naming.
hal/same51.c
Outdated
| void hal_init(void) | ||
| { | ||
|
|
||
| uint32_t reg; |
There was a problem hiding this comment.
hal/same51.c:280:14: error: unused variable 'reg' [-Werror=unused-variable]
280 | uint32_t reg;
| ^~~
| @@ -0,0 +1,113 @@ | |||
| # | |||
| # There exist several targets which are by default empty and which can be | |||
There was a problem hiding this comment.
Please add a README.md for how to use these MPLABX projects.
|
Thanks for the review, @dgarske . I have addressed the comments + re-created the two MPLAB projects + provided extended documentation. This is now ready to consider for merging. |
dgarske
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.