Added support for custom TLVs in manifest header #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgarske
requested changes
Feb 29, 2024
tools/keytools/sign.c
Outdated
| tag = (uint16_t)arg2num(argv[i + 1], 2); | ||
| len = (uint16_t)arg2num(argv[i + 2], 2); | ||
|
|
||
| if ((tag < 0x0030) || (tag > 0xFEFE)) { |
There was a problem hiding this comment.
NIT: This still allows a tag of 0xFF which is not valid (HDR_PADDING).
| This example adds a custom field when the signing tool is used to sign the firmware image: | ||
|
|
||
| ```bash | ||
| ./tools/keytools/sign --ed25519 --custom-tlv 0x34 4 0xAABBCCDD test-app/image.bin wolfboot_signing_private_key.der 4 |
There was a problem hiding this comment.
Could we add this test to one of the GitHub action tests?
danielinux
force-pushed
the
custom-tlv
branch
from
b677f55 to
0996e0f
Compare
dgarske
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support in
sign.cfor custom TLVs in the manifest header. Numeric values are supported (valid len: 1, 2, 4 or 8).[edit: custom length buffers are also supported via
--custom-tlv-buffer]The numbers are stored in little-endian format (according to the current format of the other fields). The TLVs are part of the signed image, so their value is secured against modifications.
The custom fields stored in the TLV can be retrieved at runtime in wolfboot by using
wolfBoot_find_header().Documentation is updated accordingly.