Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanups after hybrid signing PR 510 #517

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Cleanups after hybrid signing PR 510 #517

merged 1 commit into from
Oct 31, 2024

Conversation

dgarske
Copy link
Contributor

@dgarske dgarske commented Oct 30, 2024

  • Fixes issues from Support for hybrid authentication (two ciphers) #510
  • Do not change sign macro to _PRIMARY. Breaks existing users.
  • Add back "unused" on wolfBoot_image_confirm_signature_ok
  • Fix unused stored_signature_size.
  • Fix size reported in sign tool "Found RSA%d key".

@dgarske dgarske requested a review from danielinux October 30, 2024 21:59
@dgarske
Copy link
Contributor Author

dgarske commented Oct 30, 2024

@danielinux please consider these cleanups for the release.

@dgarske dgarske removed their assignment Oct 30, 2024
danielinux
danielinux approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@danielinux danielinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks David!

@danielinux danielinux merged commit aec2809 into wolfSSL:master Oct 31, 2024
99 checks passed
@dgarske dgarske deleted the post_hybrid branch October 31, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielinux danielinux danielinux approved these changes

Assignees

@danielinux danielinux

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dgarske @danielinux