drop python req from pip-build-install, move to pip-build-install, add tests #26822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoser
force-pushed
the
fix/use-setuptools-scm
branch
6 times, most recently
from
83bede7
to
34cf75c
Compare
…d tests There are lots of changes here, centered around removing all occurences of SETUPTOOLS_SCM_PRETEND_VERSION. That seems to be not necessary now, at least with the current pip-build-install workflow. * do not require 'python' setting in pip-build-install. Default to using the target of the 'python3' link. If not present, user has to supply it. Also use contextdir rather than subpkgdir so it can be used from "main" packages also. * replace any packages that had SETUPTOOLS_SCM_PRETEND_VERSION with py/pip-build-install. * py3-cppy has a runtime dep on setuptools * Add tests to touched packages * Drop 'python3' runtime dep from touched packages. * Fix uninstallable py3-gcloud-aio-storage which conflicted with its dependency py3-gcloud-aio-auth as they both provided usr/lib/python3.12/site-packages/gcloud/py.typed * Fix the provides in py3-maturin-bin packages to provide py3-maturin-bin rather than just py3-maturin. That also fixes py3-pendulum which was failing to build because it actually needs 'maturin' executable but that was not being provided by the 'py3-maturin' dep. * Fix pendulum's dependency that had py3-pytzdata, it's deps list 'tzdata' * Drop the now-unused py3-pytzdata Note the 'python3' shell snippet in py3-rich and others is painful. See wolfi-dev#26818 for more context.
smoser
force-pushed
the
fix/use-setuptools-scm
branch
from
34cf75c
to
ced2663
Compare
|
closing this for now in favor of 2 steps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are lots of changes here, centered around removing all occurences of SETUPTOOLS_SCM_PRETEND_VERSION. That seems to be not necessary now, at least with the current pip-build-install workflow.
do not require 'python' setting in pip-build-install. Default to using the target of the 'python3' link. If not present, user has to supply it.
Also use contextdir rather than subpkgdir so it can be used from "main" packages also.
replace any packages that had SETUPTOOLS_SCM_PRETEND_VERSION with py/pip-build-install.
Add tests to touched packages
Drop 'python3' runtime dep from touched packages.
Fix uninstallable py3-gcloud-aio-storage which conflicted with its dependency py3-gcloud-aio-auth as they both provided usr/lib/python3.12/site-packages/gcloud/py.typed
Fix the provides in py3-maturin-bin packages to provide py3-maturin-bin rather than just py3-maturin. That also fixes py3-pendulum which was failing to build because it actually needs 'maturin' executable but that was not being provided by the 'py3-maturin' dep.
Fix pendulum's dependency that had py3-pytzdata, it's deps list 'tzdata'
Drop the now-unused py3-pytzdata
Note the 'python3' shell snippet in py3-rich and others is painful. See #26818 for more context.