Move several py3- packages to pip-build-install, add tests. #26917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This depends on #26914 , so it will fail right now. |
I set out to get rid of SETUPTOOLS_SCM_PRETEND_VERSION, and found some issues along the way. * replace any packages that had SETUPTOOLS_SCM_PRETEND_VERSION with py/pip-build-install. * Add tests to touched packages * Drop 'python3' runtime dep from touched packages - melange sca does the right thing. * py3-cppy - add setuptools dep, found when adding a test. * py3-gcloud-aio-storage - Fix uninstallable paackage which conflicted with its dependency py3-gcloud-aio-auth. they both provided usr/lib/python3.12/site-packages/gcloud/py.typed * py3-maturin - Fix the provides in py3-maturin-bin packages to provide py3-maturin-bin rather than just py3-maturin. That fixes py3-pendulum which was failing to build because it actually needs 'maturin' executable but that was not being provided by the 'py3-maturin' dep. * py3-pendulum - fix dependency it should be tzdata not pytzdata * py3-pytzdata - Drop this, it is not used anywhere. Note the 'python3' shell snippet in py3-rich and others is painful. See wolfi-dev#26818 for more context.
smoser
force-pushed
the
fix/py3-package-fixes
branch
from
4bb8b95
to
e92110a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I set out to get rid of SETUPTOOLS_SCM_PRETEND_VERSION, and found some issues along the way.
replace any packages that had SETUPTOOLS_SCM_PRETEND_VERSION with py/pip-build-install.
Add tests to touched packages
Drop 'python3' runtime dep from touched packages - melange sca does the right thing.
py3-cppy - add setuptools dep, found when adding a test.
py3-gcloud-aio-storage - Fix uninstallable paackage which conflicted with its dependency py3-gcloud-aio-auth. they both provided usr/lib/python3.12/site-packages/gcloud/py.typed
py3-maturin - Fix the provides in py3-maturin-bin packages to provide py3-maturin-bin rather than just py3-maturin. That fixes py3-pendulum which was failing to build because it actually needs 'maturin' executable but that was not being provided by the 'py3-maturin' dep.
py3-pendulum - fix dependency it should be tzdata not pytzdata
py3-pytzdata - Drop this, it is not used anywhere.
Note the 'python3' shell snippet in py3-rich and others is painful. See #26818 for more context.