memtier-benchmark/2.1.3 package update #38869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![octo-sts[bot]](https://avatars.githubusercontent.com/in/801323?s=60&v=4){kind=small}
Contributor
octo-sts
bot
commented
Jan 6, 2025
octo-sts
bot
commented
octo-sts
bot
added
request-version-update
|
This is a legitimate test failure: the version reported by the command wasn't updated before the new tag was cut. I've filed RedisLabs/memtier_benchmark#290 with upstream. |
|
Upstream are addressing this in RedisLabs/memtier_benchmark#291, so we'll wait for that. |
|
A commit updating the version has now landed (RedisLabs/memtier_benchmark@370a25e) but the 2.1.3 tag has not been updated to point at it. I've asked upstream if they plan to update the tag (RedisLabs/memtier_benchmark#290 (comment)); if they aren't, then we can cherry-pick that commit and move on. |
OddBloke
force-pushed
the
wolfictl-cc891dac-a8a4-408a-b9d7-769f1cbcc22a
branch
from
c8d0748 to
e4d81aa
Compare
|
No response from upstream, so I've gone the cherry-pick route. |
powersj
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.