Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chromium/133.0.6943.141 package update #43780

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Feb 25, 2025

@octo-sts octo-sts bot added request-version-update request for a newer version of a package automated pr labels Feb 25, 2025
Copy link
Contributor Author

octo-sts bot commented Feb 25, 2025

⚠️ EXPERIMENTAL

Please use 👍 or 👎 on this comment to indicate if you agree or disagree with the recommendation.

To provide more detailed feedback please comment on the recommendation prefixed with /ai-verify:

e.g. /ai-verify partially helpful but I also added bash to the build environment

Gen AI suggestions to solve the build error:

Let me help analyze and fix this Git checkout error.

• Detected Error: "Expected commit cffa127ce7b6be72885391527c15b452056a2e81 for 133.0.6943.141, found 2a5d6da0d6165d7b107502095a937fe7704fcef6"

• Error Category: Version/Git Checkout

• Failure Point: Git checkout step when verifying expected commit hash

• Root Cause Analysis: The commit hash specified in the melange.yaml doesn't match the actual commit hash for the tagged version 133.0.6943.141. This is likely because the expected-commit field wasn't updated when the version was bumped.

• Suggested Fix:
Update the expected-commit hash in the git-checkout step:

  - uses: git-checkout
    with:
      repository: https://chromium.googlesource.com/chromium/src.git
      tag: ${{package.version}}
      depth: 1
      expected-commit: 2a5d6da0d6165d7b107502095a937fe7704fcef6  # Updated hash
      destination: /home/src

• Explanation:
The build system verifies the commit hash as a security measure to ensure the exact code version is being built. The mismatch occurs because the actual commit hash for version 133.0.6943.141 is different from what was specified. Updating to the correct hash will allow the checkout to proceed.

• Additional Notes:

  • The commit hash can be verified directly from Chromium's git repository
  • This type of mismatch commonly occurs during version updates when the expected-commit field isn't synchronized
  • It's important to always update both the version and commit hash together when bumping versions

• References:

@octo-sts octo-sts bot added the ai/skip-comment Stop AI from commenting on PR label Feb 25, 2025
@debasishbsws debasishbsws self-assigned this Feb 26, 2025
@debasishbsws
Copy link
Member

Working on here: #43822

@debasishbsws
Copy link
Member

#43822 this is ready to review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ai/skip-comment Stop AI from commenting on PR automated pr request-version-update request for a newer version of a package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants