Add initpkg tool to initialize a new package #240
Conversation
Signed-off-by: Ariadne Conill <[email protected]>
Signed-off-by: Ariadne Conill <[email protected]>
Signed-off-by: Ariadne Conill <[email protected]>
Signed-off-by: Ariadne Conill <[email protected]>
Signed-off-by: Ariadne Conill <[email protected]>
|
|
||
| // InterpretURI interprets the provided source code URI and fills in project | ||
| // information as well as pipeline instructions in how to fetch the sources. | ||
| func (ctx *Context) InterpretURI(uri string) error { |
There was a problem hiding this comment.
I would not use ctx as a receiver because it collides with the idiomatic name forcontext.Context parameters.
(I'd also rename the struct from Context to something else so we don't have a dozen different flavors of Context floating around, but that's less important than the receiver name.)
| Version string | ||
| License string | ||
| Layout string | ||
| WorkDir string |
There was a problem hiding this comment.
Consider having Context taking a WorkFS parameter so it's more easily tested with an apkfs.FullFS or something instead of always writing to disk.
| return err | ||
| } | ||
|
|
||
| ctx.Build.Package.Description = "TODO" |
There was a problem hiding this comment.
Maybe we can get the description from the repos API: https://docs.github.com/en/rest/repos/repos?apiVersion=2022-11-28 (if given project path is GitHub)
|
Hey @kaniini! I'm looking forward to get this PR merged. So we can iterate the features over time. Is there anything we should do? |
No description provided.