Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous emscripten fixes #510

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Commits on Jan 18, 2023

  1. emscripten: Increase stack size to 128 kB

    Emscripten's stack size was recently decreased to 64 kB from 5 MB,
    (emscripten-core/emscripten#18191).
    
    Stack overflow appears to be the cause of frequent crashes of Tracy
    in my browser, especially at start-up. This increase is modest, but
    seems to be enough to resolve the issue.
    topolarity committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    08aed0c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5492a2c View commit details
    Browse the repository at this point in the history
  3. emscripten: Scale horizontal scroll events to be reasonable

    In my browser, I noticed that zooming seemed jumpy and unreliable.
    Turns out that my fingers were moving horizontally on my trackpad,
    and the x-scroll was causing the unexpected behavior.
    topolarity committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    c71a43c View commit details
    Browse the repository at this point in the history
  4. emscripten: Increase PTHREAD_POOL_SIZE to 8.

    I never noticed this causing any user-visible deadlocks, but I saw
    warnings in the Javascript console that the thread pool was getting
    exhausted. Increasing it to this number seems to resolve the issue.
    topolarity committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    862b48a View commit details
    Browse the repository at this point in the history