Issue with Filter by Facebook Sync Setting

[sukafia]

✍️ Describe the bug

Facebook for WooCommerce ads the "Filter by Facebook sync setting" option for filtering products by Facebook sync setting in the All Products screen. However, this filter isn't correctly filtering all products associated with the sync settings.

The filter does not work on all products. For instance, when some products are assigned the “Do not sync” setting, they do not appear when filtered with that option.

• This user recorded a screencast of the issue here.

I tested this on my end and it seems the product status may play a role (e.g. draft, private, etc.)

Affected users

https://wordpress.org/support/topic/filter-by-facebook-sync-setting-not-working-in-admin-all-products
https://wordpress.org/support/topic/facebook-for-woocommerce-not-syncing-and-filter-is-not-working/

🚶‍♀️ Steps to reproduce

1. Assigned different sync settings to products (e.g. Sync and show, sync and hide, do not sync)
2. Filter the products by the assigned sync status
3. Notice some products matching the sync setting don't show when filtered by that sync setting (I even noticed a product showing up for an unrelated sync setting)

✔️ Expected behavior

Products associated with a sync setting should show up when filtered by that sync setting.

[sukafia]

I noticed something interesting while testing this

Product sync settings "Sync and hide":

The Facebook sync status shown in the product interface appears to be due to being out of stock/private. While the assigned status is "Sync and hide". It's correct for the product to appear when filtered with "Sync and hide" but this initially confused me to think a product with a "Do not sync" status was being shown for the sync and hide filter.

From this, I gathered part of the issue is the default sync status assigned due to the product status (draft, out of stock, private, etc.) and the assigned sync setting on the product editing screen.

[ibndawood]

Hello @sukafia, thank you for reporting this issue. The issue is due to the difference between the Facebook Sync status set in the product tabs and the actual sync status. The actual sync status goes through validations listed here, and if one of the validations fails, the product will not be synced even if the status is set to Sync and show.

To resolve this, we've added a tooltip to explain why the sync status is Do not sync. This should resolve the confusion around the sync status shown. Here is the PR: #2625. Please let us know what you think about this approach.

[sukafia]

@ibndawood I think the tooltip works for now. Thanks for looking into this.

[ibndawood]

Thank you, @sukafia, for your input. We've reviewed and merged PR: #2625. The tooltip should be available in the next release.