Adds a tooltip to Facebook sync status #2625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
changelog: fix
ibndawood
changed the title
|
Does this change anything in the filtering that #2616 mentions? I only see the tooltip added or am I missing something? |
|
Hello @budzanowski, thank you for taking the time to review this PR. In #2616, the issue is not due to incorrect filtering. The filter works as expected. However, while displaying the filter status in the columns, we show the actual sync status, whether a product can be synced or not, instead of the Facebook Sync status, which is set in the product data field. This PR will add an information icon to show why a |
|
@ibndawood I am sorry I was confused for a second. We have discussed this last week, all is good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Closes #2616.
When filtering products in the WooCommerce admin, the Facebook Sync status displayed in the column conflicts with the status chosen. This is because the Facebook Sync status is a product metadata whereas the displayed status is the actual sync validation based on various conditions. The list of conditions can be viewed here.
This PR will add a tool tip to the conflicting status to explain why the status is
Do not sync. This tooltip should resolve the confusion around filtering reported in #2616.phpcschecks? Please removephpcs:ignorecomments in changed files and fix any issues, or delete if not practical.Screenshots:
The Product Facebook Sync is set to Sync and show, but the visibility is set to hidden.
Tooltip to display why the product status is
Do not Sync.Detailed test instructions:
Sync and showfor theFacebook Syncfield.Catalog Visibilitytohiddenand clickUpdate.Do not sync, and a?tooltip icon will be displayed. The message should readThis product cannot be synced to Facebook because it is hidden from your store catalog..Changelog entry