Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: Instagram Checkout #1669

Draft
wants to merge 188 commits into
base: develop
Choose a base branch
from
Draft

Release: Instagram Checkout #1669

wants to merge 188 commits into from

Conversation

wvega
Copy link
Contributor

@wvega wvega commented Oct 28, 2020

⚠️ DO NOT DEPLOY ⚠️

This release contains the Instagram Checkout integration, and is not to be released to all users yet.

Summary

The feature release that includes Instagram Checkout.

Notes

  • The color, size, and pattern fields that were initially introduced as searchable fields for the Instagram Checkout feature are rendered as regular text fields after the Enhanced Catalog changes: before vs now.

Additional Stories

Final PR

TODO

Before deploy

  • I have confirmed the final PR is merged
  • I have added a changelog entry
  • Integration tests pass
  • Acceptance tests pass
  • The beta period is complete and we have confirmed this is release-ready

Pre-releases

Every time a new 2.1.x or 2.2.x version is deployed and those changes are merged into master, we should rebase this branch on top master and tag a new pre-release with the latest changes.

On your machine:

  1. Rebase the commits from this branch onto master and fix any conflicts (git rebase --onto master $(git merge-base master HEAD))
  2. Ensure integration tests and acceptance tests pass
  3. Bump the beta version (e.g. 2.3.0-beta.1 to 2.3.0-beta.2)
  4. Run npx sake deploy:preflight bump fetch_latest_wp_wc_versions bump:minreqs clean:prerelease zip --series
  5. Commit and push the resulting changes using Facebook for WooCommerce: {version-beta} Versioning as the message (example)
  6. Create and push a tag for the version (like 2.3.0-beta2 - tags are not prefixed with v)
  7. Create a new release on the repo
    1. Make sure to check to This is a pre-release checkbox at the bottom of the form
    2. Use the items from the changelog as the content of the pre-release
    3. Test that the zip file from the build/ directory can be successfully activated
    4. Attach the zip file from the build/ directory as a binary for the pre-release
    5. Publish the pre-release (example)

Dennis Kwon and others added 15 commits February 24, 2021 11:27
…ator/facebook-for-woocommerce into dkwon/remove_legacy_api_calls
- Add fix to use visible value for attribute instead of slug
- Perf: Only process EC attributes matching a given product
- Add message handler to render errors/warnings dynamically
- Handle test Commerce accounts where cta != onsite_intent
…ator/facebook-for-woocommerce into dkwon/remove_legacy_api_calls
Also, remove unnecessary debug header
…pi_calls

Remove legacy catalog sync API calls
@jconroy
Copy link
Member

jconroy commented Mar 11, 2021

@haszari @budzanowski @rcstr @danielbitzer this is the IG Checkout feature branch.

@denniskwon has indicated this should be good for testing now.

@danielbitzer
Copy link
Contributor

How to we create a test IG checkout account?

@haszari
Copy link
Member

haszari commented Apr 14, 2021

I've merged in the current master. There were various conflicts to fix but nothing major.

As part of fixing conflicts, I used 3.0.0-dev.1 as placeholder version number – to allow room for regular releases (2.4.0, 2.5.0 etc) in the next few weeks. The actual version for this release (Instagram Checkout) is still to be decided.

@haszari
Copy link
Member

haszari commented Apr 14, 2021

This runs without any fatal errors 🎉 - I see a new tab for Facebook Commerce:

Screen Shot 2021-04-14 at 4 34 59 PM

@wvega wvega removed their assignment Apr 16, 2021
@layoutd layoutd removed their request for review April 20, 2021 13:32
@rawdreeg rawdreeg changed the base branch from master to add/automatic-feed-configuration June 3, 2022 11:36
@rawdreeg rawdreeg changed the base branch from add/automatic-feed-configuration to develop June 3, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants