Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ← to Facebook Product Sets backlink for consistency. #2599

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

krutidugade
Copy link
Contributor

Changes proposed in this Pull Request:

I missed adding a backward arrow (←) to the Facebook Product Sets backlink in PR #2581. This PR adds ← to the backlink. Also, I have added a comment for translators explaining what is %s value.

  • Do the changed files pass phpcs checks? Please remove phpcs:ignore comments in changed files and fix any issues, or delete if not practical.

Screenshots:

Screenshot 2023-08-02 at 8 52 21 PM

Detailed test instructions:

  1. Install and activate Facebook for WooCommerce plugin
  2. Go to Marketing > Facebook Product Sets
  3. Edit existing Product set (if you have none then add one and then edit it)
  4. Make changes and click Save
  5. Verify the backlink label in the success notice says "← Go to Facebook Product Sets"

Changelog entry

Tweak - Adds backward arrow to Facebook Product Sets backlink.

@krutidugade krutidugade self-assigned this Aug 2, 2023
@github-actions github-actions bot added the changelog: tweak Small change, that isn't actually very important. label Aug 2, 2023
@krutidugade krutidugade requested a review from a team August 2, 2023 19:57
@krutidugade krutidugade merged commit 5eed8ca into develop Aug 3, 2023
6 checks passed
@krutidugade krutidugade deleted the tweak/backlink-fb-product-sets branch August 3, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: tweak Small change, that isn't actually very important.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants