Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds WooCommerce as a dependency to the plugin header #2733

Merged
merged 1 commit into from
May 2, 2024
Merged

Adds WooCommerce as a dependency to the plugin header #2733

merged 1 commit into from
May 2, 2024

Conversation

ibndawood
Copy link
Contributor

@ibndawood ibndawood commented May 2, 2024 •
edited
Loading

Changes proposed in this Pull Request:

Closes #2732.

In this PR, we add WooCommerce as a dependency using the Requires Plugins header.

Screenshots:

Screenshot 1

image

Screenshot 2

image

Detailed test instructions:

  1. Install and activate Facebook for WooCommerce plugin without WooCommerce activated.
  2. Verify an error notice is displayed with the message: This plugin is active but may not function correctly because required plugins are missing or inactive. (Screenshot 1)
  3. Activate WooCommerce. Verify the dependencies are displayed on the plugin screen (Screenshot 2)

Changelog entry

Tweak - Adds WooCommerce as a dependency to the plugin header

@github-actions github-actions bot added changelog: add A new feature, function, or functionality was added. type: enhancement The issue is a request for an enhancement. labels May 2, 2024
@ibndawood ibndawood self-assigned this May 2, 2024
@ibndawood ibndawood merged commit d1b345c into develop May 2, 2024
5 checks passed
@ibndawood ibndawood deleted the add/2732-wc-dependency branch May 2, 2024 07:15
@layoutd layoutd mentioned this pull request May 9, 2024
Closed
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ibndawood ibndawood

Labels
changelog: add A new feature, function, or functionality was added. type: enhancement The issue is a request for an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add WooCommerce as a plugin dependency to the plugin header
1 participant
@ibndawood